Skip to content

ui: fluid container with wider layout#703

Merged
theborakompanioni merged 3 commits intomasterfrom
ui/fluid-container
Dec 19, 2023
Merged

ui: fluid container with wider layout#703
theborakompanioni merged 3 commits intomasterfrom
ui/fluid-container

Conversation

@theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Dec 1, 2023

  • larger jars and buttons on main wallet view
  • use fluid container (container-xl) and switch column sizes from
    md={10} lg={8} xl={6}
    
    to
    lg={10} xl={10} xxl={8}
    

📸 Before / After







@theborakompanioni theborakompanioni added concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience labels Dec 1, 2023
@theborakompanioni theborakompanioni self-assigned this Dec 1, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review December 13, 2023 13:41
@theborakompanioni
Copy link
Collaborator Author

@editwentyone Feedback welcome. e.g. the balances below the jars on the main screen look weird now. Any input is highly appreciated 🙏

@editwentyone
Copy link

what do you mean? all I see is maybe right align the text? but could look strange with higher numbers before the .

Bildschirmfoto 2023-12-14 um 09 04 55

@theborakompanioni
Copy link
Collaborator Author

what do you mean? all I see is maybe right align the text? but could look strange with higher numbers before the .

Bildschirmfoto 2023-12-14 um 09 04 55

That is a separate issue.
Maybe the font size of the balance is too small for the bigger jars? 🤔

@theborakompanioni theborakompanioni merged commit 9807f37 into master Dec 19, 2023
@theborakompanioni theborakompanioni deleted the ui/fluid-container branch December 19, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants