dev: ability to reset fee values in dev mode#698
Merged
theborakompanioni merged 2 commits intomasterfrom Nov 30, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to reset fee values in dev mode.
Some fee properties (
max_cj_fee_absandmax_cj_fee_rel) do not have default values if JM is installed from scratch.You can now reset those fee values if you want to test what the UI looks like, when a user does not have these values configured.
Misc:
How to test
npm run dev:start📸
(This message was there all along.. as dev you just never really saw it)