refactor: externalize send form components#695
Merged
theborakompanioni merged 19 commits intomasterfrom Dec 1, 2023
Merged
Conversation
theborakompanioni
added
UI/UX
Collaborator
Author
|
@editwentyone Screenshots are a bit outdated. 🙏 |
theborakompanioni
force-pushed
the
refactor/send-form-components
branch
from
bffd4fa to
e65ec04
Compare
This reverts commit bad32e6.
theborakompanioni
force-pushed
the
refactor/send-form-components
branch
from
e65ec04 to
a803ded
Compare
Collaborator
Author
|
@editwentyone Now supports displaying a validation message for missing source jars: |
editwentyone
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Externalizes send form components. These changes prepare for:
New components:
SendFormAmountInputFieldDestinationInputFieldSourceJarSelectorNo functionality should have changed!
The code is still pretty rough, but way better then before.
JarSelector button in "Recipient" and Sweep button in "Amount in sats" have been adapted to better display errors states.
As a consequence, the following can be done again:
📸 Before / After