Skip to content

fix: use orderbook.json instead of parsing html table#687

Merged
theborakompanioni merged 5 commits intomasterfrom
refactor/orderbook-json
Nov 2, 2023
Merged

fix: use orderbook.json instead of parsing html table#687
theborakompanioni merged 5 commits intomasterfrom
refactor/orderbook-json

Conversation

@theborakompanioni
Copy link
Collaborator

@theborakompanioni theborakompanioni commented Oct 26, 2023

Closes #454.
Closes #561.

  • Fetches orderbook.json instead of parsing the html table to get data.
  • Uses normalized fidelity bond value
  • Removes column "Miner Fee Contribution"

📸 Before/After

@theborakompanioni theborakompanioni added UI/UX Issue related to cosmetics, design, or user experience tech dept Removes some technical debt labels Oct 26, 2023
@theborakompanioni theborakompanioni self-assigned this Oct 26, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review October 26, 2023 22:25
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@theborakompanioni theborakompanioni merged commit df81804 into master Nov 2, 2023
@theborakompanioni theborakompanioni deleted the refactor/orderbook-json branch November 2, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tech dept Removes some technical debt UI/UX Issue related to cosmetics, design, or user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Normalise Bond values or color the non-zero values? Use orderbook.json instead of parsing html table

2 participants