dev: always show logs button in dev mode#681
Merged
theborakompanioni merged 4 commits intomasterfrom Nov 2, 2023
Merged
Conversation
theborakompanioni
added
devtools
theborakompanioni
added
concept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature to show the log file is not available on all platforms.
Before this commit, the "show logs" button has only been displayed if a special endpoint indicates it is enabled.
However, this is somewhat confusing, as the endpoint is not available in the regtest environment.
So, when this commit is applied, the button will always be shown while developing.
With
npm run dev:start, the log endpoint will return an error (as it is not implemented in the dev environment, since this is interacting with a "native" JM instance) and a message is displayed to runnpm run dev:start:secondary(which interacts with an instance in thestandaloneimage, that has the log feature enabled!).Additionally, this moves the menu item from section "Markets" to "Wallet".