chore: remove create wallet button from settings page#680
Merged
theborakompanioni merged 1 commit intomasterfrom Oct 18, 2023
Merged
chore: remove create wallet button from settings page#680theborakompanioni merged 1 commit intomasterfrom
theborakompanioni merged 1 commit intomasterfrom
Conversation
theborakompanioni
added
concept
editwentyone
approved these changes
Oct 18, 2023
editwentyone
left a comment
editwentyone
left a comment
There was a problem hiding this comment.
sure, just the right thing to do
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a proposal, feel free to close it, if you think it is not a good idea.
I do not quite see the use of a "create wallet" button from the settings page.
A wallet can already be created from the main view when no wallet is active.
This PR will remove the button from the settings page.
What do you think?
📸 Before/After