i18n: add Chinese translation 🇨🇳 (Simplified & Traditional)#628
Merged
theborakompanioni merged 4 commits intojoinmarket-webui:masterfrom Jul 3, 2023
Merged
Conversation
Imported Chinese Translations from Transifex
theborakompanioni
added
the
i18n
theborakompanioni
changed the title
Collaborator
|
There are some build errors as the translation files are not imported correctly. Would you be able to make the necessary changes and verify that it works in your regtest environment? If I can be of any service, please do not hesitate to ask! 🙏 |
Fixed import formatting and added missing lines Removed remnants of the not yet merged German translation that made it into the initial pull request due to an error in branch creation.
Contributor
Author
|
Builds fine for me now. Can you confirm? :) |
Collaborator
Yes. Looks great. 🎉 |
theborakompanioni
approved these changes
Jul 3, 2023
Collaborator
theborakompanioni
left a comment
theborakompanioni
left a comment
There was a problem hiding this comment.
lgtm. I'd say we merge this now and wait for user feedback. :rocket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported the Chinese translations from Transifex that someone else did, because according to the matrix group, these are already finished.