fix(fees): allow input for relative fee limit of 0.0001%#603
Merged
Conversation
theborakompanioni
changed the title
theborakompanioni
force-pushed
the
fix/relative-fee-limit
branch
from
b060b28 to
868ab32
Compare
theborakompanioni
changed the title
theborakompanioni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #602.
This seems to have been just an oversight.
Before this PR, the fee modal did not let users specify 0.0001% as relative fee limit.
After this PR, 0.0001% is allowed and accepted as valid value.
Tested by setting "absolute fee limit" to 10 sats (makers in regest use 250 sats as absolute fee) and "relative fee limit" to 0.0001% (factor: 0.000001), then sending a collaborative transaction sweeping Jar A with 2 collaborators on regtest.
Success ✔️
Verify the transaction by watching the logs with
npm run regtest:logs:jmwalletd.