fix(fb): correctly display success screen after unlocking fb#601
Merged
fix(fb): correctly display success screen after unlocking fb#601
Conversation
dergigi
approved these changes
Feb 1, 2023
Contributor
dergigi
left a comment
dergigi
left a comment
There was a problem hiding this comment.
Looks good to me, tACK ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a bug when unlocking an expired fidelity bond: After the tx had been broadcasted, the success screen disappeared, as the modal was hidden as soon as no FB was present anymore.
With this fix, the success screen is shown correctly after an expired FB has been unlocked.
How to test?
On master, verify you can reproduce the bug: After you spend an expired Fidelity Bond, no success screen is displayed.
Then checkout this branch and repeat the procedure. This time the success screen should be displayed.