ISSUE-528: improve JarDetailsOverlay header#588
Merged
theborakompanioni merged 5 commits intojoinmarket-webui:masterfrom Jan 9, 2023
Merged
Conversation
Contributor
Author
|
I just realized this looks weird on mobal mode though: Let me work on this and resubmit. |
Contributor
Author
|
I fixed mobile mode. Reopened |
theborakompanioni
added
the
UI/UX
theborakompanioni
approved these changes
Jan 9, 2023
Collaborator
theborakompanioni
left a comment
theborakompanioni
left a comment
There was a problem hiding this comment.
Hey @Jared-Dahlke, thanks so much! Really nice.
Did some small adaptions, mostly simplification of styles.
Your contribution is highly appreciated. Looking forward to the next one 🚀 🚀 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #528
This PR moves the "UTXOS | DETAILS" tab out of the header and places it just below the header instead.
Here is screenshots of the changes:
I also made sure that all of the other instances of
<SegmentedHeader/>still look good: