fix: install python3-venv in regtest environment#585
Merged
Conversation
This was referenced Jan 3, 2023
theborakompanioni
force-pushed
the
fix/regtest-python3-venv
branch
from
2e5e735 to
c0a90f2
Compare
dergigi
approved these changes
Feb 1, 2023
Contributor
dergigi
left a comment
dergigi
left a comment
There was a problem hiding this comment.
Looks good to me, tACK ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #581
Quick workaround to make the regtest environment compatible with the current state of master (
ea7a6e) again. This can be removed once the install script is fixed upstream.Also, adapts the payjoin server port from
8080to8082according to2749da1- included in JMv0.9.9.