Conversation
theborakompanioni
requested review from
editwentyone and
secondl1ght
and removed request for
secondl1ght
theborakompanioni
force-pushed
the
fix/collab-integer
branch
from
cd0e35a to
b4d5a27
Compare
dergigi
approved these changes
Dec 9, 2022
Contributor
dergigi
left a comment
dergigi
left a comment
There was a problem hiding this comment.
Looks good to me, tACK ✅
Small NIT: imho it would be better if the input field wouldn't allow nonsense in the first place, but that's just me. This PR is definitely an improvement, so I'll merge it as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, Jam displayed and sent a fractional number as collaborators to the backend (which rounded down to the nearest int). After this commit is applied the number of collaborators as always parsed and displayed as integer.
Before:
After:
