fix: display error message if backend is unreachable#540
Merged
Conversation
dergigi
approved these changes
Oct 10, 2022
Contributor
dergigi
left a comment
dergigi
left a comment
There was a problem hiding this comment.
tACK, Looks good to me ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #538.
Changeset is based on #521 (please review/merge #521 first).
Before this PR the app showed a generic error message when the backend was unreachable.
After this PR the app displays an error message with more informative reason, e.g. "No connection to backend: Gateway Timeout.".
At first I tried implementing this behaviour via the recommended
react-router-dom'serrorElementproperty (as described in the docs). However, this did not work for reasons not yet known. I will try it again with a future release, as this is a more appropriate error handling mechanism and also enables better separation of data and views, which would be nice to have.How to test
Checkout the
masterbranch and start the app (withnpm start) without starting the regtest environment - verify that you see a generic error message. Switch to this branch (git checkout error-page) and verify that you see a more informative message.📸 Before/After