feat: display fee settings on Send page#532
Merged
theborakompanioni merged 11 commits intomasterfrom Oct 5, 2022
Merged
Conversation
theborakompanioni
force-pushed
the
feat/display-fee-settings-in-send
branch
from
00f32ca to
3dba073
Compare
theborakompanioni
added
enhancement
dergigi
approved these changes
Oct 5, 2022
Contributor
dergigi
left a comment
dergigi
left a comment
There was a problem hiding this comment.
Code looks good to me, tACK ✅
Please have a look at the adjustments I made. Feel free to merge in case you agree with them.
Contributor
|
Screenshot for reference:
|
2 tasks
2 tasks
Contributor
|
Calculations were always correct for me btw. - great job on the tests 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly addresses #518.
Display values based on fee settings in the confirmation modal of the Send page.
"Mining fee target" will be displayed either as "targeted blocks" or "sats/vByte" (randomized or exact):
e.g.
tx_fees := 1)tx_fees := 6)tx_fees := 1000)tx_fees := 1001,tx_fees_factor := 0)tx_fees := 10000,tx_fees_factor := 0.9)"Estimated Max. Collaborator Fee" will be displayed for collaborative transactions.
Calculation can be found here: https://github.com/joinmarket-webui/jam/blob/feat/display-fee-settings-in-send/src/hooks/Fees.ts#L69-L70 (Tests: https://github.com/joinmarket-webui/jam/blob/feat/display-fee-settings-in-send/src/hooks/Fees.test.ts#L22-L69)
📸
sats/vByte with randomization
sats/vByte exact
Targeted blocks
Collaborative transaction