Conversation
Member
|
Nicely done. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lollipopfetches Pfam domains and additional motif features using the InterPro REST API. If there are no Pfam domains or motif features, the REST API response will return an HTTP status of 204 (No Content). Currently, the code checks that responses have an HTTP status of 200 and exits if they don't. This pull request changes this behavior to accepts 204 HTTP responses (although no regions will be drawn in this case).Example for
CCDC61(no Pfam annotation)This pull request introduces a new option,
-D <source>, which enables the customization of the domain source. By default, it is set to Pfam (consistent with the current behavior). However, it also accepts InterPro as a source. In the case of InterPro, representative domains, selected from all domain and repeat databases within the InterPro consortium (including CDD, NCBIfam, Pfam, PROSITE, and SMART), are retrieved and then drawn.Example for
CCDC61(no Pfam annotation, but CDD annotation)There are cases where two databases of protein families and domains describe the same domain, but with slightly different annotation locations. The use of
-D interproallows for the drawing of the "best" domain, typically the longest one.Example with
PIK3CA:The Pfam PI3K-type C2 domain does not include the N345K variant.
However, the same domain described by CDD does.
Finally, in cases where the
-o <filename>option is not provided, the graphic is saved as<gene-symbol>.svg. However, if a UniProtKB accession is used instead of a gene symbol (-U <accession>), the graphic is saved as.svg. This pull request resolves this issue by using the UniProt accession for the output file.