fix: clean up landedOrderCounters on coordinator close#187
Merged
johannesjo merged 1 commit intoJun 23, 2026
Conversation
landedOrderCounters entries were never deleted when a coordinator task completed. While each entry is small (a task ID string → a number), long-running sessions with many coordinator cycles would accumulate stale entries indefinitely. Add landedOrderCounters.delete() alongside the existing coordinators.delete() in the coordinator cleanup path.
Owner
|
Thank you very much! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
landedOrderCountersMap accumulates entries keyed bycoordinatorTaskIdbut never deletes them when a coordinator closes. Over a long session with many coordinator cycles, these stale entries grow without bound — a slow memory leak.Every other Map in the same cleanup path (
coordinators,activeSignalWaitCounts, etc.) is already cleaned up on coordinator close.landedOrderCounterswas just missed.One line: add
this.landedOrderCounters.delete(coordinatorTaskId)next to the existingthis.coordinators.delete(coordinatorTaskId)call.