fix: replace noisy console.warn with structured logger in steps.ts#186
Conversation
Review — structured logger migration in
|
The step watcher was logging every send and watch event at warn level using console.warn — that's debug info, not a warning. Switched all logging to the structured logger (info for routine events, warn for actual failures) so the console isn't spammed during normal operation. Found during quality audit (johannesjo#157, finding 41).
…ug for watch events - Replace leftover console.error in readStepsFile with logError (captures full stack) - Downgrade watch-event log from info to debug (fires per file change, not just steps.json) - Promote watcher error handlers to logError so stack traces are preserved for setup failures that silently disable live step updates
d2980ba to
093e7fc
Compare
|
Thanks for the thorough review! Pushed a follow-up commit addressing all three points:
All 1420 tests pass, typecheck + lint clean. |
|
Thank you very much! <3 |
The step watcher was logging every send and every file change at
console.warnlevel — that's debug info, not a warning. In a normal session with multiple agents running, this spams the console with hundreds of entries that make real warnings impossible to spot.Switched all logging in
steps.tsto the structured logger that the rest of the main process already uses:infolevelwarnlevelFound during quality audit (#157, finding 41).