Fix sidebar selection when jumping with Cmd-number#135
Merged
Conversation
Owner
|
Thank you very much! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a task is selected with the mouse, the sidebar keeps focus and renders the selection outline from
sidebarFocusedTaskId. Using Cmd-1 through Cmd-9 changed the active task, but leftsidebarFocusedTaskIdpointing at the last mouse-selected row, so the outline stayed on the wrong task.Fix
Update
jumpToTask()so Cmd-number jumps also synchronize the sidebar focused task when the sidebar currently owns focus. The change clears project focus and moves the sidebar outline to the jumped task.Verification
npm run checknpm testjohannesjo/main, touching onlysrc/store/navigation.tsandsrc/store/navigation.test.ts.