chore: fix 404 page#133
Merged
Merged
Conversation
Contributor
Author
|
@joerdav, it looks like this PR doesn't fix the issue. The 404 page https://xcfile.dev/404.html exists, but when I go to an unknown page like https://xcfile.dev/unknown, a standard Not Found message appears:
Could you take a look? |
Owner
|
Yeah I've tried a couple of things with no luck. I think the problem is that the catch-all route is being hit: The app engine routes work top to bottom, and I think if they match even if there is no file corresponding it doesn't propagate onto the next rule. |
Owner
|
There isn't great documentation around it either. |
Owner
|
I think the answer might be to have a custom python handler? |
Owner
Contributor
Author
|
Works! Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The PR fixes the display of the 404 page on GCP App Engine by modifying
doc/app.yaml(I'm not 100% sure if this helps because I can't deploy it without GCP permissions). It also slightly modifies the style of the error page.Before:
After:
Fixes #80