fix: Break reference cycle between Actor and ActorRef#251
Merged
Conversation
Actor and ActorRef both had references to each other, creating a cycle that blocked instant memory freeing since the actor's reference count never reached zero. This changes the ActorRef reference to the actor to use a weakref, so that the ActorRef doesn't contribute to the Actor's reference count, enabling instant freeing of the memory. Fixes #249, #250
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
- Coverage 94.32% 93.84% -0.48%
==========================================
Files 14 14
Lines 581 585 +4
Branches 50 51 +1
==========================================
+ Hits 548 549 +1
- Misses 29 31 +2
- Partials 4 5 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActorandActorRefboth had references to each other, creating a cycle that blocked instant memory freeing since the actor's reference count never reached zero.This changes the
ActorRefreference to the actor to use a weakref, so that theActorRefdoesn't contribute to the actor's reference count, enabling instant freeing of the memory.Fixes #249, #250