Only allow a single Future setter to be called#240
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 93.47% 93.84% +0.37%
==========================================
Files 14 14
Lines 567 569 +2
Branches 49 50 +1
==========================================
+ Hits 530 534 +4
+ Misses 32 31 -1
+ Partials 5 4 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already raised an exception if multiple calls to
.set()and.set_exception()were done on a single future. Now, the same behavior applies to.set_get_hook().This may be a breaking change if you use
Future.set_get_hook()directly. If you only use it indirectly viaFuture.map(),.join(), and.reduce(), there is no change, as these have always created new futures with the get hook, wrapping the futures with the results to transform.Closes #235