Skip to content

Fix README cloning url#1508

Merged
tomMoral merged 1 commit into
joblib:masterfrom
andreaso:readme-clone-url
Sep 29, 2023
Merged

Fix README cloning url#1508
tomMoral merged 1 commit into
joblib:masterfrom
andreaso:readme-clone-url

Conversation

@andreaso

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Sep 29, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0569c89) 95.01% compared to head (f57b806) 94.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
- Coverage   95.01%   94.94%   -0.08%     
==========================================
  Files          45       45              
  Lines        7550     7550              
==========================================
- Hits         7174     7168       -6     
- Misses        376      382       +6     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomMoral
tomMoral merged commit 720ccd9 into joblib:master Sep 29, 2023
@tomMoral

Copy link
Copy Markdown
Contributor

Thanks for the fix! merging.

@andreaso

Copy link
Copy Markdown
Contributor Author

No problem!

On a similar note, the documentation contains a bunch of http:// urls, where it probably would preferable to use the https:// versions instead.

Would a PR rectifying that be welcomed?

@tomMoral

Copy link
Copy Markdown
Contributor

Yes! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants