Skip to content

MAINT: Cleanup expired ndarray methods#1506

Merged
lesteve merged 1 commit into
joblib:masterfrom
mtsokol:numpy-ndarray-class-cleanup
Sep 19, 2023
Merged

MAINT: Cleanup expired ndarray methods#1506
lesteve merged 1 commit into
joblib:masterfrom
mtsokol:numpy-ndarray-class-cleanup

Conversation

@mtsokol

@mtsokol mtsokol commented Sep 17, 2023

Copy link
Copy Markdown
Contributor

Hi!
This PR reflects changes introduced in numpy/numpy#24682.

@codecov

codecov Bot commented Sep 17, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (bfd14eb) 94.92% compared to head (38de320) 94.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   94.92%   94.96%   +0.03%     
==========================================
  Files          45       45              
  Lines        7550     7550              
==========================================
+ Hits         7167     7170       +3     
+ Misses        383      380       -3     
Files Changed Coverage Δ
joblib/numpy_pickle_utils.py 93.25% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsokol

mtsokol commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

Hi! Would you have a spare time to review this PR?

@lesteve
lesteve merged commit 0569c89 into joblib:master Sep 19, 2023
@lesteve

lesteve commented Sep 19, 2023

Copy link
Copy Markdown
Member

Merging, thanks!

@mtsokol
mtsokol deleted the numpy-ndarray-class-cleanup branch September 19, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants