CLN tidy logger#1439
Merged
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
- Coverage 94.78% 94.75% -0.03%
==========================================
Files 44 44
Lines 7207 7308 +101
==========================================
+ Hits 6831 6925 +94
- Misses 376 383 +7
☔ View full report in Codecov by Sentry. |
using logging.(debug,warning, etc) from within a library is unwise as it forces the end user to have a stream handler on the root logger. Now you'll be logging to the joblib namespace, so that users can specify a logging level via `logging.getLogger('joblib').setLevel(logging.DEBUG)` or whatever they want.
It adds about 10ns to each log use.
tomMoral
force-pushed
the
CLN_tidy_logger
branch
from
April 30, 2023 13:26
f779806 to
37a6fcb
Compare
|
Are there perchance any plans already when this will be released? |
Contributor
Author
|
Hi, we plan to release As we just merged a big refactor, we hope to gather feedbacks before releasing, hence the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicate of #1033 that I closed by mistake.