ENH add cache_validation_callback in Memory#1149
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
+ Coverage 94.82% 94.93% +0.10%
==========================================
Files 44 44
Lines 7366 7439 +73
==========================================
+ Hits 6985 7062 +77
+ Misses 381 377 -4
☔ View full report in Codecov by Sentry. |
tomMoral
left a comment
tomMoral
left a comment
There was a problem hiding this comment.
some improvements
|
Thx for the review @jjerphan ! I did update this a bit. I will try to finish this by adding some examples and a bit of doc. |
You're welcome.
Feel free to request a new review when it's ready. |
723eb7e to
ea1f187
Compare
|
@jjerphan I rebased the PR and did a pass on the doc, feel free to review once more :) |
|
It looks like the tests are failing in some configurations. I mostly am busy with other tasks now but will try to come back to it soon. |
jjerphan
left a comment
jjerphan
left a comment
There was a problem hiding this comment.
After discussing a few remark and changing this PR title to mention cache_validation_callback instead of validate_cache, this LGTM. 👍
tomMoral
changed the title
Co-authored-by: Julien Jerphanion <[email protected]>
|
My previous review might be outdated, let me know if you want another one, @tomMoral. |
|
This popular feature appears to have rested unmerged after passing an extended review. Sadly there are now conflicts and test failures again. Is this good to merge if it is ported forward? |
|
I just fixed this, I will try to merge it to include it in the next release. |
3 participants
Tentative to implement a way to validate the cache results with user define rules.
validate_cachethat takes a callablevalidate_cache(metadata) -> bool.timein metadata to ease the robust checking of computation time in all backends.joblib.memory.expires_afterto check the age of a cached results.Todo:
Fixes #313 .