Repository navigation
fix(mobile): iPhone compose button no longer covers the last tab - #93
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a 393pt iPhone (iPhone 15 Pro), the floating compose button sat on top of the Settings tab instead of beside the tab bar.
The native tab bar places compose 16pt after the last tab button it measures. pingdotgg#28955 (upstream) filters out the glass lens's magnified copy of the row with an exact
convert(bounds).size == bounds.sizecheck. Converting a translated rect rounds, so at some widths the last real tab fails that check. Compose then lands one tab-width too far left. The filter now compares sizes with a 1pt tolerance. The lens copy is still excluded: compose keeps its size after a tab press.Verified on an iPhone 15 Pro simulator (iOS 26.5). The bug did not appear on the 402pt iPhone 17 Pro simulator.
Done with Claude Opus 5.5 in Claude Code (T3 Code).