Skip to content

Some display changes#3

Merged
jnyrup merged 1 commit intojnyrup:best-practicesfrom
adamvoss:best-practices
Oct 1, 2017
Merged

Some display changes#3
jnyrup merged 1 commit intojnyrup:best-practicesfrom
adamvoss:best-practices

Conversation

@adamvoss
Copy link

@adamvoss adamvoss commented Oct 1, 2017

Here are some changes to consider. I think they are fairly obvious from the diff. The only one that might need comment is the "Inferior/Better" I agree that your choice was 100% correct and accurate. However, "inferior" has some negative connotations so I opted to try to avoid it to keep the language neutral.

@jnyrup
Copy link
Owner

jnyrup commented Oct 1, 2017

I tried to come up with some sort of antonym to Better, but I like your change to a more neutral language.

@adamvoss adamvoss deleted the best-practices branch October 1, 2017 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants