Improve the general flow of the website#2
Improve the general flow of the website#2adamvoss wants to merge 39 commits intojnyrup:best-practicesfrom
Conversation
- Moves the best practices to examples. - Minor wording changes to affect tone or perspective - Generally ties to make the website more intuitive for uses who do not already know what FluentAssertions is
I generally like the wording changes for examples.md. |
I wanted to show my idea in-context though and felt this was the best way to do it. Since your PR to upstream should probably be squashed a bit, I submitted fluentassertions#646 with my changes to make things easier. I would recommend abandoning this PR and you just making the appropriate changes to move things (as inspired by this) on your own branch.
Nope, I was not 😀 I was admittedly kind of confused by the "Best Practices" title when I saw it showing changes between assertion libraries. I'd recommend splitting these two things to avoid this kind of confusion. In that case I'd perhaps keep the MSTest ones under examples and have a Tips page that can be about how to write better FA assertions. In all cases, I would avoid the "old" vs "new" terminology. Given the potential connotations, I think that would only be appropriate if documenting changes between FluentAssertions versions. |
|
Thanks for all the suggestions, they are now included in 930df67 |
The idea to move your best practices to the examples page came to be as I was reviewing for #1. What do you think of the result?