Skip to content

Commit 10da6df

Browse files
committed
[tests] Remove getinfo fixups
1 parent f54f200 commit 10da6df

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

doc/developer-notes.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -613,8 +613,7 @@ A few guidelines for introducing and reviewing new RPC interfaces:
613613
from there.
614614

615615
- A RPC method must either be a wallet method or a non-wallet method. Do not
616-
introduce new methods such as `getinfo` and `signrawtransaction` that differ
617-
in behavior based on presence of a wallet.
616+
introduce new methods that differ in behavior based on presence of a wallet.
618617

619618
- *Rationale*: as well as complicating the implementation and interfering
620619
with the introduction of multi-wallet, wallet and non-wallet code should be

test/functional/bitcoin_cli.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,18 @@ def __init__(self):
1414
self.num_nodes = 1
1515

1616
def run_test(self):
17-
"""Main test logic"""
1817

1918
self.log.info("Compare responses from gewallettinfo RPC and `bitcoin-cli getwalletinfo`")
20-
cli_get_info = self.nodes[0].cli.getwalletinfo()
21-
rpc_get_info = self.nodes[0].getwalletinfo()
22-
23-
assert_equal(cli_get_info, rpc_get_info)
19+
assert_equal(self.nodes[0].cli.getwalletinfo(), self.nodes[0].getwalletinfo())
2420

2521
self.log.info("Compare responses from getblockchaininfo RPC and `bitcoin-cli getblockchaininfo`")
26-
cli_get_info = self.nodes[0].cli.getblockchaininfo()
27-
rpc_get_info = self.nodes[0].getblockchaininfo()
22+
assert_equal(self.nodes[0].cli.getblockchaininfo(), self.nodes[0].getblockchaininfo())
23+
24+
self.log.info("Compare responses from getmininginfo RPC and `bitcoin-cli getmininginfo`")
25+
assert_equal(self.nodes[0].cli.getmininginfo(), self.nodes[0].getmininginfo())
2826

29-
assert_equal(cli_get_info, rpc_get_info)
27+
self.log.info("Compare responses from getnetworkinfo RPC and `bitcoin-cli getnetworkinfo`")
28+
assert_equal(self.nodes[0].cli.getnetworkinfo(), self.nodes[0].getnetworkinfo())
3029

3130
if __name__ == '__main__':
3231
TestBitcoinCli().main()

0 commit comments

Comments
 (0)