fix: Disable grapheme cluster probe on LineDisciplineTerminal#1709
Merged
fix: Disable grapheme cluster probe on LineDisciplineTerminal#1709
Conversation
ExternalTerminal has no real terminal emulator on the other end, so the DECRQM mode 2027 probe should not be sent. The probe would either consume actual input data from the pipe (causing readLine() to hang) or leak the escape sequence into the output stream (corrupting downstream consumers). This fixes two issues: - LineReaderTest hanging when the terminal type starts with "xterm" because the probe consumes input meant for readLine() - Maven embedded executor tests failing on Windows because the probe escape sequence [?2027$p contaminates captured output paths
gnodet
force-pushed
the
fix/disable-grapheme-probe-linediscipline
branch
from
fe33b5c to
581cbb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
supportsGraphemeClusterMode()inLineDisciplineTerminalto returnfalse, preventing the DECRQM mode 2027 probe from being sent on terminals with no real terminal emulatorFixes #1707
LineDisciplineTerminal(and subclassesExternalTerminal,SwingTerminal,WebTerminal) have no real terminal emulator on the other end, so the DECRQM probe either:readLine()to hang forever (the LineReaderTest hang #1707 issue)[?2027$pinto the output stream, corrupting downstream consumers (the Maven CI failure)Test plan
LineReaderTestnow passes (was hanging due to probe consuming piped input)@Disabledtests)