Conversation
When running in environments without a TTY (e.g., CI), the "Unable to create a system terminal" warning is expected and unhelpful. This change suppresses the warning when providers are available but detect that no streams are TTYs, while still warning when no providers could be loaded (indicating a genuine configuration issue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1703 to
jline-3.x.Summary
Context
When JLine is used in CI environments (like GitHub Actions), the warning "Unable to create a system terminal, creating a dumb terminal" is emitted even though falling back to a dumb terminal is the expected behavior when no TTY is available. This creates noise in build logs (e.g., https://github.com/apache/camel/actions/runs/23203983845/job/67434869843#step:11:68).
The fix distinguishes three cases:
noTty=true, providers not empty → warning suppressedproviders.isEmpty()=true→ warning firesnoTty=false→ warning firesTest plan
DumbTerminalWarningTest.testNoWarningWhenNoTtyAndProvidersAvailable— verifies no warning in CI-like environmentsDumbTerminalWarningTest.testWarningWhenNoProvidersLoaded— verifies warning when no providers are available