fix: Disable grapheme cluster probe on Windows PosixSysTerminal#1696
Merged
fix: Disable grapheme cluster probe on Windows PosixSysTerminal#1696
Conversation
The previous fix (#1695) only blocked the DECRQM probe when using ExecPty and the output stream was not detected as a system stream. This was insufficient because the isSystemStream() check is unreliable on Windows MSYSTEM environments — it can return true for streams that are being captured by a parent process. Simplify the guard to disable the probe entirely on Windows PosixSysTerminal. On Windows, PosixSysTerminal only exists for Cygwin/MSYSTEM environments where the slave output goes to a raw FileDescriptor, making the probe inherently risky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[?2027$pleaking into subprocess outputisSystemStream()check is unreliable on Windows MSYSTEM environments (can return true for streams that are being captured by a parent process)PosixSysTerminal, since the slave output always goes to a rawFileDescriptorwhich makes probing inherently riskyFixes the remaining CI failure: https://github.com/apache/maven/actions/runs/22931697655/job/66554940328
Test plan
GraphemeClusterModeTesttests pass