fix: Move consumer POM flattening to .mvn/maven.properties (fixes #1688)#1694
Merged
fix: Move consumer POM flattening to .mvn/maven.properties (fixes #1688)#1694
Conversation
The maven.consumer.pom.flatten property must be set in .mvn/maven.properties (a Maven configuration property), not in pom.xml <properties> (a project property). When set in the POM, it was ignored and child consumer POMs still retained a <parent> reference to jline-parent (which uses modelVersion 4.1.0), breaking Maven 3 and Gradle consumers. Workaround for apache/maven#11772
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven.consumer.pom.flatten=truefrompom.xml<properties>to.mvn/maven.properties<parent>reference tojline-parent(which uses modelVersion 4.1.0)Before (consumer POM still had parent reference):
After (self-contained consumer POM):
Fixes #1688
Workaround for apache/maven#11772