Repository navigation
Commit 7c18a85
[linux] Read heading text through the AtkText interface (flutter#188005)
Fixes flutter#187925
## Problem
On Linux, a node with `Semantics(header: true)` is announced by Orca as
just **"header"** — the node's text is never read. With `header: false`
the same text is read correctly.
## Root cause
Two issues in the Linux embedder's accessibility code
(`engine/src/flutter/shell/platform/linux/`):
1. **The node's label is exposed only via the `AtkObject` name property,
not the `AtkText` interface.** Orca reads the text content of a heading
**exclusively through `AtkText`** (see `_generate_heading` in Orca's
`speech_generator.py`, which calls `_generate_text_content` →
`AXText.get_substring` → `atk_text_get_text`). It never falls back to
the name for the heading/header roles. So Orca finds no text and
announces only the role.
This matches the ATK contract used by GTK: `GtkLabel` exposes its text
through `AtkText`. Flutter's label **is** its text content, so it should
be exposed the same way. (`FlAccessibleTextField` already does this for
editable text.)
2. **The wrong ATK role.** `is_header` maps to `ATK_ROLE_HEADER`, which
is the *document masthead/banner* role. `ATK_ROLE_HEADING` is the
*content-heading* role (the HTML `<h1>`–`<h6>` analogue) and is what
`Semantics(header: true)` means (matching iOS `header` trait and Android
heading class).
## Fix
* Implement the `AtkText` interface on `FlAccessibleNode`, backed by the
node's existing accessibility name (`get_character_count`, `get_text`,
`get_character_at_offset`, `get_caret_offset`, `get_n_selections`,
`get_selection`, `get_text_at_offset`). This is safe for other roles:
Orca's default presentation for buttons/panels/images reads the
`AtkObject` name via `_generate_accessible_label_and_name`, not
`AtkText`, so their announcement is unchanged. `FlAccessibleTextField`
already declares a richer `AtkText` and continues to override the base
implementation.
* Map the `is_header` flag to `ATK_ROLE_HEADING`.
## Result
For the repro in flutter#187925, Orca now announces **"Section One, heading"**
instead of just **"header"**.
## Test plan
- [x] Added `ExposesTextViaAtkText` test verifying
`atk_text_get_character_count` / `atk_text_get_text` /
`atk_text_get_character_at_offset` return the node's label.
- [x] Extended the existing role-mapping test to assert `is_header` →
`ATK_ROLE_HEADING`.
- [ ] `Linux linux_unit_tests` (cannot run locally — Linux GTK/ATK
build; developed/analyzed on macOS). Reviewers, please confirm CI is
green.
---------
Co-authored-by: Robert Ancell <[email protected]>1 parent 6807bd9 commit 7c18a85
2 files changed
Lines changed: 224 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
75 | 76 | | |
76 | 77 | | |
77 | 78 | | |
| |||
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
84 | | - | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
85 | 88 | | |
86 | 89 | | |
87 | 90 | | |
| |||
240 | 243 | | |
241 | 244 | | |
242 | 245 | | |
243 | | - | |
| 246 | + | |
244 | 247 | | |
245 | 248 | | |
246 | 249 | | |
| |||
547 | 550 | | |
548 | 551 | | |
549 | 552 | | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
| 593 | + | |
| 594 | + | |
| 595 | + | |
| 596 | + | |
| 597 | + | |
| 598 | + | |
| 599 | + | |
| 600 | + | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
| 622 | + | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
| 644 | + | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
| 648 | + | |
| 649 | + | |
| 650 | + | |
| 651 | + | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
| 659 | + | |
| 660 | + | |
| 661 | + | |
| 662 | + | |
| 663 | + | |
| 664 | + | |
| 665 | + | |
| 666 | + | |
| 667 | + | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
| 671 | + | |
| 672 | + | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
550 | 714 | | |
551 | 715 | | |
552 | 716 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
336 | 336 | | |
337 | 337 | | |
338 | 338 | | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
339 | 397 | | |
340 | 398 | | |
341 | 399 | | |
| |||
0 commit comments