webhooks: fix agentRoutes no-op routing + gws in image#19
Merged
Conversation
agentRoutes was declared in config types and schema but dropped in resolveWebhooksConfig and never passed to the dispatch call. Any user with hooks.webhooks.agentRoutes configured would silently get no-op routing. - Add agentRoutes to WebhooksConfigResolved - Pass agentRoutes through in resolveWebhooksConfig - Add agentId to dispatchAgentHook parameter type - Look up agentRoutes[source] and pass as agentId in dispatch call - Set agentId on CronJob in server/webhooks.ts so isolated-agent uses it - 2 new tests: routed preset passes agentId, unrouted preset omits it Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Quick follow-up to PR #18 — Greptile flagged a real bug where
agentRouteswas silently doing nothing, plus a couple of staging hardening improvements.Summary
agentRouteswas declared in the config type and schema but dropped inresolveWebhooksConfig— any user withhooks.webhooks.agentRoutes: { "shopify": "peterino" }would silently get default-agent routing. Now threads all the way through toCronJob.agentId.@googleworkspace/cli(gws) into the image so it's always available on fresh deploys, not dependent on the persistent volume.Changes
webhooks-http.tsagentRoutestoWebhooksConfigResolved; passagentIdto dispatchserver/webhooks.tsagentIdonCronJob; add to inline parameter typehooks.tsagentRoutesthroughresolveWebhooksConfigwebhooks-http.test.tsDockerfile@googleworkspace/clito npm install blockscripts/staging-up.shTest plan
pnpm buildcleanpnpm check— 0 warnings, 0 errors🤖 Generated with Claude Code