Repository navigation
Commit 5b4192f
committed
[flutter_tools] Shut down isolates in --experimental-faster-testing when suite channels close
When running multiple test files with `--experimental-faster-testing`, lightweight engine isolates remained alive because `IsolateChannel` ports lack an EOF disconnect signal on the child isolate. This caused isolates and native threads to accumulate across suites.
Notify the child test isolate when the suite runner closes the channel sink, and invoke native `ForceShutdownIsolate` followed by `Isolate.exit()` once the suite channel completes. Also unregister port names from `IsolateNameServer` and remove closed channels from the root isolate spawner map.
Fixes flutter#1466031 parent 66b3ad9 commit 5b4192f
2 files changed
Lines changed: 89 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
352 | 352 | | |
353 | 353 | | |
354 | 354 | | |
| 355 | + | |
355 | 356 | | |
356 | 357 | | |
357 | 358 | | |
| |||
406 | 407 | | |
407 | 408 | | |
408 | 409 | | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
409 | 417 | | |
410 | 418 | | |
411 | 419 | | |
| |||
424 | 432 | | |
425 | 433 | | |
426 | 434 | | |
| 435 | + | |
| 436 | + | |
| 437 | + | |
427 | 438 | | |
428 | | - | |
| 439 | + | |
429 | 440 | | |
430 | | - | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
431 | 448 | | |
432 | 449 | | |
433 | 450 | | |
| |||
610 | 627 | | |
611 | 628 | | |
612 | 629 | | |
613 | | - | |
614 | | - | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
| 636 | + | |
| 637 | + | |
| 638 | + | |
| 639 | + | |
| 640 | + | |
| 641 | + | |
| 642 | + | |
| 643 | + | |
615 | 644 | | |
616 | | - | |
| 645 | + | |
617 | 646 | | |
618 | 647 | | |
619 | 648 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
877 | 877 | | |
878 | 878 | | |
879 | 879 | | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
| 909 | + | |
| 910 | + | |
| 911 | + | |
| 912 | + | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
| 921 | + | |
| 922 | + | |
| 923 | + | |
| 924 | + | |
| 925 | + | |
| 926 | + | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
880 | 935 | | |
881 | 936 | | |
882 | 937 | | |
| |||
0 commit comments