This repository was archived by the owner on Feb 15, 2024. It is now read-only.
Use libtool with versioned ABI #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasschnelli
force-pushed
the
2015/09/LT_INIT
branch
from
ef7f64c to
f106310
Compare
jonasschnelli
force-pushed
the
2015/09/LT_INIT
branch
from
f106310 to
5b312dc
Compare
jonasschnelli
changed the title
Contributor
Author
|
Added proper libtool versioning (@jgarzik: please review in detail). |
Owner
|
Update looks pretty good, and passes travis. Seems to match my experience with https://github.com/jgarzik/hail Comments:
In general looks good, thanks! |
Contributor
Author
|
Added the Maybe striping out _ symbols won't work with C++? |
jgarzik
pushed a commit
that referenced
this pull request
Sep 23, 2015
Use libtool with versioned ABI
luke-jr
pushed a commit
to luke-jr/univalue
that referenced
this pull request
Mar 10, 2018
…s "explicit" fe805ea Declare single-argument (non-converting) constructors "explicit" (practicalswift) Pull request description: Rebased on jgarzik#4. Closes jgarzik#6, which stripped the original author. Tree-SHA512: 4f4164fb1bbce54e5e28a5cf1327c4d7a2058e74384d1173de843acbfb71a3dc4a11e559650b86c6ac9063ea9c76c96fa371bff985d794c8dc904448f4ecd095
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses libtool to build the library and should therefore solve issues like: https://travis-ci.org/bitcoin/bitcoin/jobs/79127433#L1480