Added capability to support docker pull with image sha #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluxxBot
commented
Dec 12, 2025
| } | ||
|
|
||
| // Returns the physical Artifactory repository name of the pulled/pushed image, by reading a response header from Artifactory. | ||
| func (image *Image) GetRemoteRepoAndManifestTypeAndLeadSha(serviceManager artifactory.ArtifactoryServicesManager) (string, string, string, error) { |
Collaborator
Author
There was a problem hiding this comment.
removed this function since a problem was identified where response was missing headers X-Artifactory-Filename
fluxxBot
changed the title
4 tasks
bhanurp
requested changes
Dec 21, 2025
Collaborator
bhanurp
left a comment
bhanurp
left a comment
There was a problem hiding this comment.
lets retry running go fmt some imports are not grouped properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added support for collecting build info for sha based image resolution from artifactory, for example:
docker command ->
jf docker pull <registry>/<namespace>/<image>@sha:xyz --build-name <build-name> --build-number <build-number>depends on: