Skip to content

Added helm commands integrations for collecting build info #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
naveenku-jfrog merged 25 commits into from
Dec 9, 2025
Merged

Added helm commands integrations for collecting build info #314

naveenku-jfrog merged 25 commits into from
Dec 9, 2025

Conversation

@naveenku-jfrog
Copy link
Collaborator

@naveenku-jfrog naveenku-jfrog commented Nov 26, 2025 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

what: Added functionalities for collecting build info by downloading dependencies info through artifactory API for helm commands.
Testing: done, locally
Dependent on other PRs: Yes, jfrog/build-info-go#339

@naveenku-jfrog naveenku-jfrog added the new feature Automatically generated release notes label Nov 26, 2025
bhanurp
bhanurp requested changes Dec 7, 2025
View reviewed changes
artifactory/commands/helm/oci_manifest.go Outdated
)

// downloadFileContentFromArtifactory downloads a file from Artifactory and returns its content
func downloadFileContentFromArtifactory(serviceManager artifactory.ArtifactoryServicesManager, repo, path, name string) ([]byte, error) {
Copy link
Collaborator

@bhanurp bhanurp Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant we extract this info from local?

Copy link
Collaborator Author

@naveenku-jfrog naveenku-jfrog Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non oci helm chart, priority is first checking inside cache, then artifactory,
but for oci, we need to search manifest and config layers from artifactory itself.

bhanurp
bhanurp reviewed Dec 8, 2025
View reviewed changes
bhanurp
bhanurp approved these changes Dec 9, 2025
View reviewed changes
@naveenku-jfrog naveenku-jfrog force-pushed the feature/Added-native-helm-commands-support branch from 5c25eb1 to 40a2bb4 Compare December 9, 2025 13:34
@naveenku-jfrog naveenku-jfrog force-pushed the feature/Added-native-helm-commands-support branch from 40a2bb4 to 44b7fe7 Compare December 9, 2025 13:35
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.

@naveenku-jfrog naveenku-jfrog merged commit 7395f6f into jfrog:main Dec 9, 2025
11 checks passed
nitinp19 pushed a commit to nitinp19/jfrog-cli-artifactory that referenced this pull request Dec 11, 2025
@naveenku-jfrog @bhanurp @nitinp19
Added helm commands integrations for collecting build info (jfrog#314)
0a79dbf 
Co-authored-by: Bhanu Reddy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhanurp bhanurp bhanurp approved these changes

Assignees

No one assigned

Labels

new feature Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@naveenku-jfrog @bhanurp