-
Notifications
You must be signed in to change notification settings - Fork 35
Introduced support for docker build command #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bhanurp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unit test cases are required.
c27b364 to
9c5c52e
Compare
9c5c52e to
a864aa8
Compare
a864aa8 to
a9957ca
Compare
a9957ca to
18db14c
Compare
6bd6a6f to
14e9b3f
Compare
799b258 to
cbd31bb
Compare
bhanurp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file names doesn't look consistent like dockerbuild_artifacts.go instead of docker_build_artifacts.go, lets stick to one format.
This PR aims to introduce support for docker build and buildx command while maintaing the legacy usage.
Implements docker build, docker buildx and legacy build commands using the Strategy pattern to support different execution modes based on the JFROG_RUN_NATIVE environment variable.
changes:
New Strategy Pattern Implementation: Three strategies for Docker build execution:
-> RunNativeStrategy: Direct Docker build and buildx execution (JFROG_RUN_NATIVE=true)
-> LegacyStrategy: Traditional JFrog approach (default)
depends on: