Skip to content

Conversation

@fluxxBot
Copy link
Collaborator

@fluxxBot fluxxBot commented Oct 15, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • Appropriate label is added to auto generate release notes.
  • I used gofmt for formatting the code before submitting the pull request.
  • PR description is clear and concise, and it includes the proposed solution/fix.

This PR aims to introduce support for docker build and buildx command while maintaing the legacy usage.

Implements docker build, docker buildx and legacy build commands using the Strategy pattern to support different execution modes based on the JFROG_RUN_NATIVE environment variable.

changes:

New Strategy Pattern Implementation: Three strategies for Docker build execution:
-> RunNativeStrategy: Direct Docker build and buildx execution (JFROG_RUN_NATIVE=true)
-> LegacyStrategy: Traditional JFrog approach (default)

depends on:

  1. Introduced support for docker build command jfrog-cli#3165
  2. Added on demand log level to debug for add props jfrog-client-go#1269

@fluxxBot fluxxBot added ignore for release Automatically generated release notes new feature Automatically generated release notes labels Oct 15, 2025
Copy link
Collaborator

@bhanurp bhanurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test cases are required.

@fluxxBot fluxxBot removed the ignore for release Automatically generated release notes label Nov 10, 2025
@fluxxBot fluxxBot changed the title Added skeleton code for docker build command Added support for docker build command Nov 12, 2025
@fluxxBot fluxxBot changed the title Added support for docker build command Introduced support for docker build command Nov 12, 2025
@fluxxBot fluxxBot requested review from bhanurp and nitinp19 November 13, 2025 05:03
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Dec 4, 2025
Copy link
Collaborator

@bhanurp bhanurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file names doesn't look consistent like dockerbuild_artifacts.go instead of docker_build_artifacts.go, lets stick to one format.

@fluxxBot fluxxBot added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 4, 2025
@fluxxBot fluxxBot added the safe to test Approve running integration tests on a pull request label Dec 9, 2025
@fluxxBot fluxxBot merged commit c05dd49 into jfrog:main Dec 9, 2025
11 of 12 checks passed
nitinp19 pushed a commit to nitinp19/jfrog-cli-artifactory that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Automatically generated release notes safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants