Fix inconsistent RequestedBy Paths for .NET Dependencies #3279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bhanurp
added
the
safe to test
Contributor
bhanurp
added
safe to test
itsmeleela
approved these changes
Dec 19, 2025
agrasth
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Description:
Fix inconsistent RequestedBy Paths for .NET Dependencies
Summary
This PR fixes a bug where direct dependency attribution for .NET projects was inconsistent across multiple runs of jf audit or Frogbot. The "Direct Dependency" column and impact paths would change unpredictably, even with the same project and source code.
Root Cause
The root cause was non-deterministic Go map iteration order in the dependency resolution code. When a dependency appeared as both direct AND transitive (e.g., Newtonsoft.Json is a direct dependency and also a transitive dependency of NuGet.Core), the RequestedBy paths would be populated in random order across runs, causing:
Inconsistent direct dependency attribution - A dependency could flip between "direct" and "transitive" across runs
Flaky vulnerability reports - Impact paths would change between scans
Non-reproducible build-info - Same project producing different outputs
Depends on
jfrog/build-info-go#349