Skip to content

Conversation

@reshmifrog
Copy link
Contributor

@reshmifrog reshmifrog commented Dec 9, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Problem: The jf rt curl command was fragile , it was incorrectly treating the boolean flags like -L, -v, -s as if they needed a value, causing it to skip the API path.
Solution: We created a list of all curl flags that are boolean flags. When parsing, if a flag is in this list, we don't skip the next argument. If it's not in the list, we assume it needs a value and skip the next argument. For combined flags like -Lo, we scan each character - once we find a flag that needs a value, anything after it is treated as its inline value(e.g -Lotest.txt).

@reshmifrog reshmifrog added the safe to test Approve running integration tests on a pull request label Dec 9, 2025
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 9, 2025
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 9, 2025
@reshmifrog reshmifrog changed the title update dependencies curl-command-parsing-issue Dec 10, 2025
@reshmifrog reshmifrog added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@agrasth agrasth added safe to test Approve running integration tests on a pull request and removed safe to test Approve running integration tests on a pull request labels Dec 10, 2025
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@agrasth agrasth enabled auto-merge (squash) December 10, 2025 11:32
@agrasth agrasth merged commit fb1baab into jfrog:master Dec 10, 2025
70 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants