Skip to content

Conversation

@reshmifrog
Copy link
Contributor

@reshmifrog reshmifrog commented Sep 17, 2025

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Problem: We were experiencing an issue where artifacts are not being resolved according to the defined resolution order in a virtual repository when using the JFrog CLI.

Solution: Added the support for direct download command bypassing the aql

  • Added the e2e tests for it

Screenshot 2025-11-06 at 3 27 04 PM Screenshot 2025-11-06 at 3 17 21 PM Screenshot 2025-11-06 at 3 16 46 PM

@reshmifrog reshmifrog added the improvement Automatically generated release notes label Sep 17, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@reshmifrog reshmifrog force-pushed the add-support-for-direct-download-cmd branch from 9d298cb to 87a0379 Compare September 22, 2025 08:40
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@fluxxBot
Copy link
Contributor

make sure to change the label to feature instead of improvement, in this PR and related PRs

@fluxxBot
Copy link
Contributor

also check why tests are failing

@RemiBou RemiBou added the jfrog-internal Items created by jfrog employees label Oct 17, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2025
go.mod Outdated
// Should not be updated to 0.2.6 due to a bug (https://github.com/jfrog/jfrog-cli-core/pull/372)
github.com/c-bata/go-prompt => github.com/c-bata/go-prompt v0.2.5

github.com/jfrog/jfrog-cli-artifactory => github.com/reshmifrog/jfrog-cli-artifactory v0.0.0-20251106084927-a0665c1a6808
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to remove replace statements and update SHA directly

@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 6, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 10, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Nov 10, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2025
@github-actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@reshmifrog reshmifrog requested a review from fluxxBot November 10, 2025 06:51
@reshmifrog reshmifrog changed the title add direct download cmd support-direct-download-cmd-bypassing-aql Nov 10, 2025
@reshmifrog reshmifrog merged commit e47e9ab into jfrog:master Nov 10, 2025
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jfrog-internal Items created by jfrog employees new feature Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants