Defend against spoon-feeding readers not fully populating the scanning buffer #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In addition to fixing the default and nested skeletons, this PR adds a new testsuite case that reproduces the problem with one test using the existing default skeleton, and then with another test demonstrates that the fixed default skeleton actually fixes the problem. |
lsf37
reviewed
Jan 25, 2019
Member
lsf37
left a comment
lsf37
left a comment
There was a problem hiding this comment.
Nice! I've added it to the 1.7.1 milestone and we should merge it before the Unicode PR so we can pull it into the 1.7.1 branch easily.
Contributor
Author
|
squash-merged into master, and then cherry-picked into branch-1.7.1. |
regisd
pushed a commit
that referenced
this pull request
Jan 25, 2019
Author: Steve Rowe <[email protected]> Date: Fri Jan 25 10:49:57 2019 -0500 #538: Defend against spoon-feeding readers not fully populating the scanning buffer (#543) Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #538