-
Notifications
You must be signed in to change notification settings - Fork 121
Add support for Unicode 10.0 #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // based on data files downloaded from unicode.org. | ||
| public class UnicodeProperties { | ||
|
|
||
| /** Constant {@code UNICODE_VERSIONS="1.1, 1.1.5, 2, 2.0, 2.0.14, 2.1, 2.1.9,"{trunked}} */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@regisd : how are these javadoc comments generated? I don't know how to put them back.
|
TODO: Add examples/tests for Unicode segmentation rules (UAX#29 & UAX#14) under testsuite cases Note that I had done this for all Unicode versions from 5.2->8.0, but didn't get to it for 9.0, so I plan on adding 9.0's along with 10.0's under this PR. |
…uster, and Word Break rules; also remove executable attribute from files that don't need it.
…luster, and Word Break rules
|
This is ready to go. I've included it in the 1.8 milestone, though, since I don't think adding Unicode version support belongs in a patch release, so I'm going to hold off merging until we've either released or decided to skip 1.7.1. |
lsf37
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine from my side. It'd be nicer to not remove the generated comments, but I presume we can put them back in when we figure out how to.
Author: Steve Rowe <[email protected]> Date: Fri Jan 25 12:10:11 2019 -0500 Add support for Unicode 10.0 (#540) * Add support for Unicode 10.0 * Add example/test Unicode 9.0 & 10.0 grammars for Line, Sentence, Grapheme Cluster, and Word Break rules Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
No description provided.