Skip to content

Use @Autovalue #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
regisd merged 9 commits into from
Oct 23, 2018
Merged

Use @Autovalue #505

regisd merged 9 commits into from
Oct 23, 2018

Conversation

@regisd
Copy link
Member

@regisd regisd commented Oct 22, 2018

Roll forward of #433

@AutoValue is a build-time dependency that helps to remove boiler-plate code in value objects.

  • It improves code health
  • This would fix avoid coding mistakes such as Fix PMD violations #413
  • It also makes the value object immutable ; which is another good practice to avoid bugs.

See https://github.com/google/auto/blob/master/value/userguide/index.md

N.B AutoValue Release 1.5 requires JDK8 ; hence using old version https://github.com/google/auto/releases/tag/auto-value-1.5

regisd added 5 commits October 22, 2018 19:07
@regisd
# This is a combination of 3 commits.
40b26da 
# This is the 1st commit message:

Move compile.sh in main repo

# This is the commit message #2:

Download auto-value from mvn central

# This is the commit message #3:

curl -o takes an output file, not dir
@regisd
Move compile.sh in main repo
27f8cda 
Download auto-value from mvn central

Make IntPair public

Prefer wget over curl
@regisd
Use wget to download rather than curl
e48d24a
@regisd
git clone must be in directory "repo"
6dc8680
@regisd
Remove multiple dep on junit
09e0499
@regisd regisd requested a review from lsf37 as a code owner October 22, 2018 17:11
@regisd regisd mentioned this pull request Oct 22, 2018
Closed
@regisd regisd self-assigned this Oct 22, 2018
@regisd regisd added the code quality Code health and clean-up label Oct 22, 2018
@regisd regisd added this to the 1.7.1 milestone Oct 22, 2018
@regisd regisd changed the title Rollforward Use @Autovalue Use @Autovalue Oct 22, 2018
@regisd regisd force-pushed the rollforward-autovalue branch from 1bc7d4d to 3f3ebbd Compare October 22, 2018 20:28
@regisd regisd merged commit 679eac2 into jflex-de:master Oct 23, 2018
@regisd regisd deleted the rollforward-autovalue branch October 23, 2018 09:51
regisd pushed a commit that referenced this pull request Oct 23, 2018
@traviscibot
Pseudo-Merge commit 679eac2
eeef850 
Author: Régis Décamps <[email protected]>
Date:   Tue Oct 23 11:51:44 2018 +0200

    Use @autovalue (#505)

    * Use @autovalue on IntPair

    * Construct IntPair via factory method

    * Add BUILD dep on auto_value

    * add pom dep on auto-value

    * Download auto-value from mvn central for aggregated-java-sources

Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
@regisd regisd mentioned this pull request Oct 23, 2018
Merged
@lsf37 lsf37 modified the milestones: 1.7.1, 1.8.0 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lsf37 lsf37 Awaiting requested review from lsf37 lsf37 is a code owner

Assignees

@regisd regisd

Labels

code quality Code health and clean-up

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@regisd @lsf37