Skip to content

Conversation

@regisd
Copy link
Member

@regisd regisd commented Oct 10, 2018

@AutoValue is a build-time dependency that helps to remove boiler-plate code in value objects.

  • It improves code health
  • This would fix avoid coding mistakes such as Fix PMD violations #413
  • It also makes the value object immutable ; which is another good practice to avoid bugs.

See https://github.com/google/auto/blob/master/value/userguide/index.md

N.B AutoValue Release 1.5 requires JDK8 ; hence using old version https://github.com/google/auto/releases/tag/auto-value-1.5

Remove the ant build for JFlex.
It adds mainteance cost but provides no benefit.
@regisd regisd added the code quality Code health and clean-up label Oct 10, 2018
@regisd regisd added this to the 1.7.1 milestone Oct 10, 2018
@regisd regisd requested a review from lsf37 as a code owner October 10, 2018 21:56
@regisd regisd self-assigned this Oct 14, 2018
@regisd regisd merged commit d6a8362 into jflex-de:master Oct 14, 2018
@regisd regisd deleted the autovalue branch October 14, 2018 15:08
regisd added a commit that referenced this pull request Oct 14, 2018
@regisd regisd mentioned this pull request Oct 14, 2018
@regisd regisd removed this from the 1.7.1 milestone Oct 14, 2018
regisd added a commit that referenced this pull request Oct 14, 2018
This was referenced Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality Code health and clean-up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant