Skip to content

generalise warning suppression #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lsf37 merged 9 commits into from
Jan 5, 2023
Merged

generalise warning suppression #1020

lsf37 merged 9 commits into from
Jan 5, 2023

Conversation

@lsf37
Copy link
Member

@lsf37 lsf37 commented Jan 5, 2023 •
edited
Loading

  • use a set of suppressed warnings
  • add API for warning suppression
  • add CLI for warning suppression
  • add lex spec directives for warning suppression
  • add to docs

@lsf37 lsf37 requested a review from regisd as a code owner January 5, 2023 00:39
@lsf37 lsf37 self-assigned this Jan 5, 2023
@lsf37 lsf37 added the enhancement Feature requests label Jan 5, 2023
@lsf37 lsf37 added this to the 1.9.0 milestone Jan 5, 2023
lsf37 added 8 commits January 5, 2023 16:14
@lsf37
jflex: fix warning
3ef800c
@lsf37
jflex Options: add javadoc
3d8ff25
@lsf37
jflex logging: warnings with arguments
6538cce 
This should make all remaining uses of plain string warnings obsolete.
Depcrecates `void warning(String message)`.
@lsf37
jflex: eliminate uses of Out.warnings(String)
5edb14e 
The only remaining uses are now in test cases.
@lsf37
jflex: keep a set of suppressed warnings
f983d4d
@lsf37
replace Options.unused_warning with suppress/enable
8d030c6
@lsf37
jflex: make warning suppression available from CLI
cd9bbd5 
- keep a set of configurable warnings in ErrorMessages
- CLI: add --warn-all/--no-warn-all to switch on/off all warnings
- CLI: --warn-<warning> enables a warning
- CLI: --no-warn-<warning> suppresses a warning
@lsf37
jflex: add %suppress and %warn directives
c1648cf
@lsf37 lsf37 mentioned this pull request Jan 5, 2023
Closed
@lsf37 lsf37 merged commit 825d08c into master Jan 5, 2023
@lsf37 lsf37 deleted the warnings branch January 5, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@regisd regisd Awaiting requested review from regisd regisd is a code owner

Assignees

@lsf37 lsf37

Labels

enhancement Feature requests

Projects

None yet

Milestone

1.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@lsf37