Skip to content

Comments

Add givePageIndex() to provide the index of the scrolled page to a prop function#40

Merged
jfilter merged 2 commits intojfilter:masterfrom
lowewenzel:master
Oct 29, 2018
Merged

Add givePageIndex() to provide the index of the scrolled page to a prop function#40
jfilter merged 2 commits intojfilter:masterfrom
lowewenzel:master

Conversation

@lowewenzel
Copy link
Contributor

@lowewenzel lowewenzel commented Oct 24, 2018

Example usage:

...
getPageIndex = (pageIndex) => {
  this.setState({
    pageIndex,
  });
}

render() {
  return (
    <Onboarding givePageIndex={this.getPageIndex}
       ...

@jfilter jfilter merged commit b8713c1 into jfilter:master Oct 29, 2018
@jfilter
Copy link
Owner

jfilter commented Oct 29, 2018

Thanks for your work!

I renamed the prop to pageIndexCallback. The full example is then:

...
getPageIndex = (pageIndex) => {
  this.setState({
    pageIndex,
  });
}

render() {
  return (
    <Onboarding pageIndexCallback={this.getPageIndex}
       ...

@jfilter jfilter mentioned this pull request Oct 29, 2018
Closed
@ilbertt
Copy link

ilbertt commented Jul 1, 2021

I have a problem with this callback.
My code:

const [pageIndex, setPageIndex] = useState(0);

const changePageHandler = (index) => {
    setPageIndex(index);
}

<Onboarding pageIndexCallback={changePageHandler}
       ...
/>

I get this warning:

Warning: Cannot update a component from inside the function body of a different component.
at [native code]:null in dispatchAction
at screens/StartScreen.tsx:74:8 in StartScreenComponent
at [native code]:null in performSyncWorkOnRoot
at [native code]:null in callFunctionReturnFlushedQueue

I also tried to wrap changePageHandler in a useCallback hook, but the warning persists.

@lucidprojects
Copy link

lucidprojects commented Feb 21, 2022

I have the same problem as @Luca8991. Did anyone find a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lowewenzel @jfilter @ilbertt @lucidprojects