Title
Add support for GitHub App Client ID (alphanumeric) in addition to numeric App ID
Description
In a recent pull request into Kargo (akuity/kargo#4606), maintainers addressed the need to support GitHub Client ID alongside the traditional numeric App ID, because GitHub now recommends using the Client ID for authentication.
However, that implementation highlights a gap: jferrl/go-githubauth currently only supports the numeric App ID, via its NewApplicationTokenSource(appID, privateKey) API.
We’d like to request a feature enhancement:
Feature Request
- Support passing GitHub App’s Client ID (alphanumeric) to generate a JWT-based
TokenSource, alongside the existing App ID support.
Title
Add support for GitHub App Client ID (alphanumeric) in addition to numeric App ID
Description
In a recent pull request into Kargo (akuity/kargo#4606), maintainers addressed the need to support GitHub Client ID alongside the traditional numeric App ID, because GitHub now recommends using the Client ID for authentication.
However, that implementation highlights a gap:
jferrl/go-githubauthcurrently only supports the numeric App ID, via itsNewApplicationTokenSource(appID, privateKey)API.We’d like to request a feature enhancement:
Feature Request
TokenSource, alongside the existing App ID support.